Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5846: Fix output path for kudu libraries ......................................................................
IMPALA-5846: Fix output path for kudu libraries Prior to this patch, libraries and executables built using ADD_EXPORTABLE_LIBRARY (i.e. those built from be/src/kudu) were placed in their source directory - not in be/build/<etc>. The problem appears to be related to how LIBRARY_OUTPUT_PATH was set by ADD_EXPORTABLE_LIBRARY. I confess I don't completely understand the bug, but this more idiomatic (and clear, IMHO) way of setting the output dirs has the expected behaviour. Change-Id: I73f3dd5435bceb35bc929ff6d5f2c92300e2a1d2 Reviewed-on: http://gerrit.cloudera.org:8080/7818 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins --- M cmake_modules/kudu_cmake_fns.txt 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73f3dd5435bceb35bc929ff6d5f2c92300e2a1d2 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong <[email protected]>
