Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code ......................................................................
Patch Set 4: Code-Review+2 Here is the perf analysis of this jira [1]. This regresses the S3 metadata loading performance by ~25% but we decide to make it up with multi threaded loading in the subsequent patch. I discussed this with Alex, Dimitris and Mostafa and they are ok with this change not being included in 2.10.0. Given 2.10.0 is branched, now, I'm submitting this for a GVO. Rebased, removed some dead code, carrying +2. [1] https://docs.google.com/spreadsheets/d/1yD47O2aIqqWP6UOBQdemdWpK-sGSpK8eyvR4HBSYUyw/edit?usp=sharing -- To view, visit http://gerrit.cloudera.org:8080/7652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I963d647bd2ba11e3843c6ef2ac6be113c74280bf Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: No
