Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7861/1/common/thrift/generate_error_codes.py File common/thrift/generate_error_codes.py: PS1, Line 328: memory-based admission control > are we ready to recommend that widely? maybe we should just say "admission I think we already do recommend it if you have a very specific set of use cases. If you think this message would imply to some users that it might work in all cases, then I agree with your simplification. -- To view, visit http://gerrit.cloudera.org:8080/7861 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e367e1b0cb08e11fdd0546880df23b785e3b7c9 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
