Matthew Mulder has posted comments on this change. Change subject: Update stress test with admission control rejected messages ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7854/2/tests/stress/concurrent_select.py File tests/stress/concurrent_select.py: PS2, Line 950: caught_msg == "cancelled": > Either way is okay with me. I guess if we don't take the concurrent_select. As infrequently as the stress test is run on older versions of Impala, I doubt it's worth putting version logic in for this. The least I would do is remove this check, and the most I would do is move this check to its own if block that simply logs a helpful message that this is not supposed to happen after 2.9. -- To view, visit http://gerrit.cloudera.org:8080/7854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2f6fa7c0f4e5875fcb92af8f712009ffa02c964 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Matthew Mulder <mmul...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
