Henry Robinson has posted comments on this change. Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0 ......................................................................
Patch Set 4: (1 comment) Also fix a bug in how the options are checked after setting. http://gerrit.cloudera.org:8080/#/c/7859/4/source/thrift/thrift-0.9.0-patches/0011-CLD-Patch-11-IMPALA-5849-Don-t-use-compile-time-chec.patch File source/thrift/thrift-0.9.0-patches/0011-CLD-Patch-11-IMPALA-5849-Don-t-use-compile-time-chec.patch: PS4, Line 35: SSL_OP_NO_TLSv1_2 0x08000000L > Thanks for the explanation. I think it would be good to add a comment to th I think that comment would just explain in words what the code does - it's pretty clear that if the return value from SSL_CTX_set_options isn't what we expect, we throw an error. -- To view, visit http://gerrit.cloudera.org:8080/7859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I437703b2221cba6a2c3079c540ccbda571f8db0e Gerrit-PatchSet: 4 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
