Thomas Tauber-Marshall has posted comments on this change. Change subject: Include-what-you-use for Kudu client ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7872/1/be/src/exprs/kudu-partition-expr.h File be/src/exprs/kudu-partition-expr.h: PS1, Line 21: #include <kudu/client/client.h> : #include <kudu/common/partial_row.h> > can you try to just forward declare instead of including here (then includi That gives an error of the form: 'unique_ptr.h:74:22: error: invalid application of ‘sizeof’ to incomplete type ‘kudu::KuduPartialRow’' -- To view, visit http://gerrit.cloudera.org:8080/7872 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd041b783a9b7764f4b251291e0be5ed000485ce Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
