Tim Armstrong has posted comments on this change. Change subject: IMPALA-5317: add DATE_TRUNC() function ......................................................................
Patch Set 3: Code-Review+1 (1 comment) LGTM but would like someone else to check I didn't miss any edge cases http://gerrit.cloudera.org:8080/#/c/7313/2/be/src/exprs/udf-builtins.cc File be/src/exprs/udf-builtins.cc: Line 260: } > Done. Its already inside the the namespace {} block. Ahh I see. Didn't notice that. -- To view, visit http://gerrit.cloudera.org:8080/7313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I953ba006cbb166dcc78e8c0c12dfbf70f093b584 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: sandeep akinapelli <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: sandeep akinapelli <[email protected]> Gerrit-HasComments: Yes
