David Knupp has posted comments on this change. Change subject: IMPALA-5617: Include full workload name in tpch_nested query filenames ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7891/3/tests/query_test/test_tpch_nested_queries.py File tests/query_test/test_tpch_nested_queries.py: Line 36: def test_tpch_q1(self, vector): > So, I'm going to offer a comment in the spirit of this being a good opportu Actually, on later reflection, the vector might complicate this. If this seems hard to do, or makes test reporting hard to parse, then feel free to ignore this. -- To view, visit http://gerrit.cloudera.org:8080/7891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie067b201ae20b4f4c61a98be7ac1ec5a3f8febd8 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Wood <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Matthew Mulder <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Tim Wood <[email protected]> Gerrit-HasComments: Yes
