Michael Ho has posted comments on this change.

Change subject: Updates several .gitignore files.
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7902/1/.gitignore
File .gitignore:

PS1, Line 41: benchmark_results.json
benchmark_results*.json ?


http://gerrit.cloudera.org:8080/#/c/7902/1/be/.gitignore
File be/.gitignore:

PS1, Line 10: src/kudu/rpc/rtest.proxy.*
            : src/kudu/rpc/rtest.service.*
May help to do *.proxy.h *.proxy.cc *.service.h *.service.cc, similar to *.pb.h 
and *.pb.cc below.


-- 
To view, visit http://gerrit.cloudera.org:8080/7902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife446e40756864f2a19ae4393ac503d17d91996b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vuk Ercegovac <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-HasComments: Yes

Reply via email to