Dan Hecht has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation ......................................................................
Patch Set 6: (2 comments) Havent looked through all the code yet but had a high level question. http://gerrit.cloudera.org:8080/#/c/7730/6//COMMIT_MSG Commit Message: Line 28: variables or direct declarations in classes. any reason Thread and ThreadPool don't follow the same pattern? i.e. both use the private-constructor-static-create pattern, or both use the public-constructor-but-init-required pattern? I think either patterns are fine, but if there's not a good reason for different patterns, maybe pick one and use it everywhere? http://gerrit.cloudera.org:8080/#/c/7730/6/be/src/util/thread.h File be/src/util/thread.h: PS6, Line 158: thread nit: 'thread' -- To view, visit http://gerrit.cloudera.org:8080/7730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15a2f278dc71892b7fec09593f81b1a57ab725c0 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
