Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5855: reserve enough memory for preaggs ......................................................................
IMPALA-5855: reserve enough memory for preaggs The calculation in the planner failed to account for the behaviour of Suballocator, which needs to obtain at least one buffer to allocate any memory. Testing: Added a regression test that caused a crash before the fix. Updated planner tests. Was able to run local stress test binary search to completion (it previously crashed). Change-Id: I870fbe2f1da01c6123d3716a1198376f9a454c3b Reviewed-on: http://gerrit.cloudera.org:8080/7871 Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com> Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/planner/AggregationNode.java M testdata/workloads/functional-planner/queries/PlannerTest/max-row-size.test M testdata/workloads/functional-planner/queries/PlannerTest/mt-dop-validation.test M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test M testdata/workloads/functional-planner/queries/PlannerTest/spillable-buffer-sizing.test M testdata/workloads/functional-query/queries/QueryTest/admission-reject-min-reservation.test M testdata/workloads/functional-query/queries/QueryTest/aggregation.test 7 files changed, 81 insertions(+), 67 deletions(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I870fbe2f1da01c6123d3716a1198376f9a454c3b Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
