Michael Ho has posted comments on this change. Change subject: IMPALA-4670: Introduces RpcMgr class ......................................................................
Patch Set 1: (11 comments) http://gerrit.cloudera.org:8080/#/c/7901/1//COMMIT_MSG Commit Message: Line 16: > Could you also mention that there are no services that use KRPC, added in t Done http://gerrit.cloudera.org:8080/#/c/7901/2/be/src/rpc/rpc-mgr.cc File be/src/rpc/rpc-mgr.cc: PS2, Line 56: CpuInfo::num_cores() > Is it safe to trust CpuInfo across all platforms, dockers and VMs? I suppose so or it's a bug in CpuInfo. PS2, Line 65: Must call RegisterService() before StartServices() > I think this would be clearer as: Done PS2, Line 85: DCHECK(IsResolvedAddress(address)); > This is redundant. The DCHECK is already inside TNetworkAddressToSockaddr() This is mostly for documentation purpose. PS2, Line 111: status.IsRemoteError() > Is this necessary? Isn't it implied by: Not sure if it's fair to always make the assumption that kudu::rpc::ErrorStatusPB::ERROR_SERVER_TOO_BUSY implies it must come from a remote error. The KRPC code and test check for both so may make sense to be consistent with them. http://gerrit.cloudera.org:8080/#/c/7901/2/be/src/rpc/rpc-mgr.h File be/src/rpc/rpc-mgr.h: PS2, Line 129: The RPC layer continues to run. > I think this needs a little more explanation, else it's confusing as to wha Done http://gerrit.cloudera.org:8080/#/c/7901/2/be/src/rpc/rpc-mgr.inline.h File be/src/rpc/rpc-mgr.inline.h: PS2, Line 36: DCHECK(IsResolvedAddress(address)); > This is redundant. The DCHECK is already inside TNetworkAddressToSockaddr() It's useful for documentation purpose. http://gerrit.cloudera.org:8080/#/c/7901/2/be/src/runtime/exec-env.h File be/src/runtime/exec-env.h: PS2, Line 194: Impala backend server > thrift based Impala backend server Done PS2, Line 197: KRPC-based service > KRPC-based server? Done http://gerrit.cloudera.org:8080/#/c/7901/2/be/src/util/network-util.cc File be/src/util/network-util.cc: PS2, Line 120: kudu::Sockaddr > just "Sockaddr" Done http://gerrit.cloudera.org:8080/#/c/7901/2/be/src/util/network-util.h File be/src/util/network-util.h: Line 23: namespace kudu { class Sockaddr; } > namespace kudu { Done -- To view, visit http://gerrit.cloudera.org:8080/7901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8adb10ae375d7bf945394c38a520f12d29cf7b46 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
