Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5589: change "set" in imapla-shell to show empty string for unset query options ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7886/1//COMMIT_MSG Commit Message: PS1, Line 7: IMPALA-5589: change "set" in imapla-shell to show empty string for unset query options > an impala shell test would be nice too added a simple test here. PS1, Line 7: imapla > this would be the name of our imap server Done PS1, Line 40: : The other users of this state, I think HiveServer2's OpenSession() : call and HiveServer2's response to a "SET" query are affected. It seems : like they'd benefit from the same fix, but I've not been able to : adequately run through that code path. > you can add a hs2 test in tests/hs2/ , probably test_hs2.py Done http://gerrit.cloudera.org:8080/#/c/7886/1/be/src/service/query-options.h File be/src/service/query-options.h: PS1, Line 103: that > that aren't set and lack defaults Done PS1, Line 104: considered "unset", which is mapped > this is just a bit wordy, I think this makes it more clear: Done -- To view, visit http://gerrit.cloudera.org:8080/7886 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86bc06a58d67b099da911293202dae9e844c439b Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-HasComments: Yes
