Alex Behm has posted comments on this change. Change subject: IMPALA-5871: KuduPartitionExpr incorrectly handles its child types ......................................................................
Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7922/1/fe/src/main/java/org/apache/impala/analysis/KuduPartitionExpr.java File fe/src/main/java/org/apache/impala/analysis/KuduPartitionExpr.java: PS1, Line 76: children_.set( > So in defense of the people who originally wrote and reviewed this code (i. Easy to miss this. Good insights. -- To view, visit http://gerrit.cloudera.org:8080/7922 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44cf31e46a77f3e7c92cf6b9112653808a001705 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
