Tianyi Wang has posted comments on this change. Change subject: IMPALA-5867: Fix bugs parsing 2-digit year ......................................................................
Patch Set 2: (2 comments) Added some test cases testing 1400/9999 edge cases. http://gerrit.cloudera.org:8080/#/c/7910/1/be/src/runtime/timestamp-parse-util.cc File be/src/runtime/timestamp-parse-util.cc: Line 370: } > Ah ok, I misunderstood the purpose of the old code The old code actually se Changed back to a if block. http://gerrit.cloudera.org:8080/#/c/7910/2/be/src/runtime/timestamp-parse-util.cc File be/src/runtime/timestamp-parse-util.cc: Line 320: date RealignYear(const DateTimeParseResult& dt_result, > nit: can you declare this as a static method in the class for consistency. Done -- To view, visit http://gerrit.cloudera.org:8080/7910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4f430caea88b6c33f8050a1984ee0ee32ecb0a1 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
