Dan Hecht has posted comments on this change. Change subject: IMPALA-5885: free runtime filter allocations in Parquet ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7931/3/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 1030: FreeLocalAllocationsForConjuncts(); > I don't think we do actually. The FreeLocalAllocations() call is unnecessar Are you referring to HdfsScanNodeBase::Close()? That one is closing the filter_ctxs_ owned by the scan node, but the one here and in ScannerThread() is the per-thread copy. Or are you talking about a different Close()? I don't see where the scanner's Close() does it, but maybe I missed that. -- To view, visit http://gerrit.cloudera.org:8080/7931 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecdda6af12d5ca578f7d2cb393e9cb9f49438f09 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
