Alex Behm has posted comments on this change. Change subject: IMPALA-5210: Count rows and collection items in parquet scanner separately ......................................................................
Patch Set 8: (4 comments) lgtm after minor comment fixes http://gerrit.cloudera.org:8080/#/c/7776/8/be/src/exec/hdfs-parquet-scanner.h File be/src/exec/hdfs-parquet-scanner.h: Line 478: /// used to reduce the frequency updating HdfsScanNode counter. It is updated by the ... the frequency of updating the corresponding HdfsScanNode counter. Line 479: /// callees of AssembleRows() and is merged into HdfsScanNode counter at the end of into the HdfsScanNode counter Line 554: /// allocated from 'coll_value_builder'. Increases 'this->coll_items_read_counter_' by this-> is not necessary because our "_" suffix already indicates this is a member http://gerrit.cloudera.org:8080/#/c/7776/8/be/src/exec/scan-node.h File be/src/exec/scan-node.h: Line 153: /// # nested collection items read from the scanner. For example, for schema # items the scanner read into CollectionValues. For example, ... (The new sentence is more accurate because a query like "select oid from mydb.customers.orders" does scan a nested collection, but the values are materialized into top-level tuples) -- To view, visit http://gerrit.cloudera.org:8080/7776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f6efddaea18507482940f5bdab7326b6482b067 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-HasComments: Yes
