Alex Behm has posted comments on this change. Change subject: IMPALA-1641: adds an end-to-end test to capture current behavior. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7937/1/testdata/workloads/functional-query/queries/QueryTest/alter-table-hdfs-caching.test File testdata/workloads/functional-query/queries/QueryTest/alter-table-hdfs-caching.test: Line 112: # IMPALA-1641: tests that ALTER <SRC_TABLE> SET LOCATION results in no action when No need for this test - we already have exactly the same one in AnalyzeDDLTest#TestAlterTableSetCached. I think we should abandon this review and resolve the JIRA based on your latest comments. -- To view, visit http://gerrit.cloudera.org:8080/7937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82c4894eeb35272f3b905069360dfbd49fe1255a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-HasComments: Yes
