Tim Armstrong has posted comments on this change. Change subject: IMPALA-5902: add ThreadSanitizer build ......................................................................
Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/7977/1/be/src/common/init.cc File be/src/common/init.cc: Line 142: // The metric is refreshed whenever memory is consumed or released via a MemTracker, A while back I changed the Process MemTracker under ASAN to use a metric. This makes it reasonable to call this. Line 199: #ifndef THREAD_SANITIZER > Why can't we run this with TSAN? Should the #ifndef go inside that function There are alternative implementations of the atomic ops for TSAN. That function is not even compiled under TSAN. http://gerrit.cloudera.org:8080/#/c/7977/1/be/src/runtime/query-exec-mgr.cc File be/src/runtime/query-exec-mgr.cc: Line 115: // tcmalloc and address sanitizer cannot be used together > nit: "or thread" Done http://gerrit.cloudera.org:8080/#/c/7977/1/be/src/util/default-path-handlers.cc File be/src/util/default-path-handlers.cc: Line 139: ss << "Memory tracking is not available with address sanitizer builds."; > nit: "or thread" Done http://gerrit.cloudera.org:8080/#/c/7977/1/be/src/util/memory-metrics.cc File be/src/util/memory-metrics.cc: PS1, Line 86: asan > naming? Done http://gerrit.cloudera.org:8080/#/c/7977/1/be/src/util/memory-metrics.h File be/src/util/memory-metrics.h: Line 136: /// Alternative to TCMallocMetric if we're running under Address Sanitizer, which > Naming? Done http://gerrit.cloudera.org:8080/#/c/7977/1/bin/start-impalad.sh File bin/start-impalad.sh: PS1, Line 104: 7 > How did you pick 7? 7 is the maximum value. I saw a few instances where the errors didn't include all info because it was aged otu of the history. https://github.com/google/sanitizers/wiki/ThreadSanitizerFlags I guess I should use the same for the other daemons too for consistency. http://gerrit.cloudera.org:8080/#/c/7977/1/tests/common/environ.py File tests/common/environ.py: Line 135: either compiled with code coverage enabled or a sanitizer. > except ubsan I wasn't sure if UBSAN was just missing from this file - is it just treated as a normal debug build? -- To view, visit http://gerrit.cloudera.org:8080/7977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22f8faeefa5e157279c5973fe28bc573b7606d50 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
