Alex Behm has posted comments on this change. Change subject: IMPALA-4620: Refactor evalcost computation in query analysis ......................................................................
Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/7948/2/fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java File fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java: Line 240: (float) (getAvgStringLength(getChild(0)) + getAvgStringLength(getChild(1))) * > The original code here (with different parenthesis position) doesn't seem c Good point. http://gerrit.cloudera.org:8080/#/c/7948/1/testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test File testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test: Line 218: | predicates: functional.alltypessmall.string_col = '15', functional.alltypessmall.id + 15 = 27 > string_col = '15': Thanks for clarifying and nice to hear that this patch fixed a few bugs! -- To view, visit http://gerrit.cloudera.org:8080/7948 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibec3d648532c185d4318476796b1ba432b0fe59e Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-HasComments: Yes
