Zach Amsden has posted comments on this change. Change subject: IMPALA-4513: Promote integer types for ABS() ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8004/1/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 4219: TestValue("abs(-1 * cast(pow(2, 31) as int))", TYPE_BIGINT, 2147483648); Obviously there is going to be some debate about what to do about BIGINT types. Let's do that in the JIRA. -- To view, visit http://gerrit.cloudera.org:8080/8004 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86cc880e78258d5f90471bd8af4caeb4305eed77 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
