Pranay Singh has posted comments on this change. Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8034/1/be/src/exec/exec-node.h File be/src/exec/exec-node.h: PS1, Line 215: MemTracker* decoder_mem_tracker() { return decoder_mem_tracker_.get(); } > The dictionary is only used for Parquet, so I think the MemPool should not I also think using existing memory pool, dictionary_pool_ is a better option, I missed it. I'll use dictionary_pool_ instead http://gerrit.cloudera.org:8080/#/c/8034/1/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: PS1, Line 213: dict_decoder_(new MemPool(parent->scan_node_->decoder_mem_tracker())), > It is important not to create objects on a per-column basis unless truly ne I'll use dictionary_pool_ instead of creating a new memory pool for every column reads http://gerrit.cloudera.org:8080/#/c/8034/1/be/src/util/dict-encoding.h File be/src/util/dict-encoding.h: PS1, Line 234: *val_ptr = *dict_[index]; > dict_ needs to return T's directly rather than T*'s. This is a performance I'll use memcpy to copy the contents of dictionary to the buffer passed. -- To view, visit http://gerrit.cloudera.org:8080/8034 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02a3b54f6c107d19b62ad9e1c49df94175964299 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Pranay Singh Gerrit-HasComments: Yes
