Tim Armstrong has posted comments on this change. Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar ......................................................................
Patch Set 2: (3 comments) It's a bit unfortunate that we have to pull in this much code to get it to work, but it seems like you've already pruned out the unnecessary stuff. http://gerrit.cloudera.org:8080/#/c/8035/2//COMMIT_MSG Commit Message: Line 23: 'common/yarn-extras', taken from Hadoop 2.6.0. Is the original source code that you cribbed this from available publicly somewhere? Would be handy to diff. http://gerrit.cloudera.org:8080/#/c/8035/2/common/yarn-extras/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationConfiguration.java File common/yarn-extras/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationConfiguration.java: Line 19: //YARNUTIL: MODIFIED Is there an easy way I can see the diff? If you point me to the hadoop source this was derived from I can do it myself. http://gerrit.cloudera.org:8080/#/c/8035/2/fe/pom.xml File fe/pom.xml: Line 111: <scope>system</scope> Is systemPath necessary? We seem to be able to resolve data-source-api above without specifying this. -- To view, visit http://gerrit.cloudera.org:8080/8035 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7efdd8ebea298836ca2a82c0a4ae037ac9285bcf Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
