Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5597: Try casting targetExpr when building runtime filter plan ......................................................................
IMPALA-5597: Try casting targetExpr when building runtime filter plan This patch fixes a bug that fails a precondition check when generating runtime filter plans. The lhs and rhs or join predicate might have different types when the eq predicate function accepts wildcard-typed parameters. In this case in existing code the types of source and target expr will be found mismatch and an exception will be thrown when generating runtime filters. This patch tries to cast target expr to be of the same type as source expr. A testcase is added to joins.test Change-Id: I0d66673e280ce13cd3a514236c0c2ecbc50475a6 Reviewed-on: http://gerrit.cloudera.org:8080/7949 Reviewed-by: Alex Behm <[email protected]> Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java M fe/src/main/java/org/apache/impala/analysis/Expr.java M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java M testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-propagation.test M testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test 6 files changed, 53 insertions(+), 16 deletions(-) Approvals: Impala Public Jenkins: Verified Alex Behm: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d66673e280ce13cd3a514236c0c2ecbc50475a6 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang <[email protected]>
