Tim Armstrong has posted comments on this change. Change subject: IMPALA-3437: DECIMAL_V2: avoid implicit decimal->double conversion ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/7916/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java: Line 1386: Type.DOUBLE, ScalarType.createDecimalType(2, 1)); > That's the current behaviour and it does treat literals consistently with o So I guess the current behaviour seems OK to me but I haven't thought deeply. Maybe it's worth revisiting but that's a separate discussion from handling of literals. -- To view, visit http://gerrit.cloudera.org:8080/7916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie419a75784eec2294947103e6e1465dfadfc29da Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
