Joe McDonnell has posted comments on this change. Change subject: IMPALA-1649 Pass precision to Print TCounterType::DOUBLE_VALUE ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7725/2/be/src/util/pretty-printer.h File be/src/util/pretty-printer.h: PS2, Line 142: case TUnit::DOUBLE_VALUE: { : double output = static_cast<double>(value); : ss << std::setprecision(precision) << output << " "; I think TUnit::DOUBLE_VALUE is so similar to TUnit::UNIT that we should be looking to remove uses of DOUBLE_VALUE and allow UNIT to specify a precision. -- To view, visit http://gerrit.cloudera.org:8080/7725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc63d8a59bdf175341097df143798fb1a957d93f Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-HasComments: Yes
