Alex Behm has posted comments on this change.

Change subject: IMPALA-5932: Improve the transitive closure computation 
performance in value transfer graph
......................................................................


Patch Set 1:

(4 comments)

nice

http://gerrit.cloudera.org:8080/#/c/8098/1//COMMIT_MSG
Commit Message:

Line 7: IMPALA-5932: Improve the transitive closure computation performance in 
value transfer graph
Shrink to fit


Line 9: This patch implements Floyd-Warshall algorithm for the transitive
the Floyd-Warshall algorithm


Line 10: closure computation in value transfer graph, replacing the existing N^4
closure computation for the value transfer graph


http://gerrit.cloudera.org:8080/#/c/8098/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:

Line 2703:             if (!valueTransfer_[p[i]][p[j]]) continue;
Comment that this optimization works because our graphs are typically sparse


-- 
To view, visit http://gerrit.cloudera.org:8080/8098
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb00e3c1f904e60ae25567a52b4bf0809a84c6b3
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-HasComments: Yes

Reply via email to