Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5927: Fix enable_distcc for zsh
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8049/2//COMMIT_MSG
Commit Message:

Line 12: This change makes zsh temporarily emulate sh to make enable_distcc work
Update


http://gerrit.cloudera.org:8080/#/c/8049/2/bin/clean.sh
File bin/clean.sh:

Line 77: $IMPALA_HOME/bin/clean-cmake.sh
nit: maybe quote "$IMPALA_HOME" for consistency

Although this file already has three different forms of path :(


-- 
To view, visit http://gerrit.cloudera.org:8080/8049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88284e4f68c309bb46ce4b5a842ccc576cd487ed
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to