Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5954: Set DO_NOT_UPDATE_STATS in alterTable() RPCs to HMS. ......................................................................
Patch Set 1: -Code-Review (2 comments) Sorry, got a couple more questions after going through the code again. Will +1 again once I understand those scenarios. http://gerrit.cloudera.org:8080/#/c/8112/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: Line 800: partition.putToParameters(MetastoreShim.statsGeneratedViaStatsTaskParam()); Are partition level stats also affected, just wanted to make sure that we don't need to set it here as well. PS1, Line 822: Pair<String, String> statsTaskParam = MetastoreShim.statsGeneratedViaStatsTaskParam(); : msTbl.putToParameters(statsTaskParam.first, statsTaskParam.second); This looks redundant and is overwritten anyway right? -- To view, visit http://gerrit.cloudera.org:8080/8112 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05c63315579d66efeaa4c65105372ae68820ab2f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-HasComments: Yes
