Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8110 )
Change subject: IMPALA-5955: Use totalSize tblproperty instead of rawDataSize. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8110/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8110/1//COMMIT_MSG@9 PS1, Line 9: Today, Impala populates the 'rawDataSize' property : during COMPUTE STATS for the purpose of extrapolating : row counts based on file sizes. : : Intended meaning/use of tblproperties: : - rawDataSize' is the estimated in-memory size of a table : (without encoding and compression) : - 'totalSize' represents the on-disk size : : Using the fields correctly is important for compatibility : with other users of the HMS such as Hive and SparkSQL. : For example, SparkSQL relies on the 'totalSize' for : join ordering. Although this is very informative, I don't think I understand what this commit changes. Will we be populating both rawDataSize and totalSize, replace one with the other, or something else? http://gerrit.cloudera.org:8080/#/c/8110/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/8110/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1178 PS1, Line 1178: droppedRawDataSize rename to droppedTotalSize to be consistent with the tblproperty being updated? -- To view, visit http://gerrit.cloudera.org:8080/8110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7c2c4e1e99b297c849f9f0d18b2bef34ad811c6 Gerrit-Change-Number: 8110 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Comment-Date: Thu, 21 Sep 2017 18:21:43 +0000 Gerrit-HasComments: Yes
