Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8025 )
Change subject: IMPALA-5844: use a MemPool for expr local allocations ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/8025/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8025/6//COMMIT_MSG@13 PS6, Line 13: * They are freed in bulk at various points in query execution. > I'm not suggesting we can't manage them in bulk for convenience. But what Yeah I think I was thinking at a slightly different level - all the pointers are freed at the same time so they're being managed as a batch. The fact that the implementation keeps track of the pointers individually is an implementation choice. http://gerrit.cloudera.org:8080/#/c/8025/6//COMMIT_MSG@13 PS6, Line 13: * They are freed in bulk at various points in query execution. > we don't have to do it that way though. It does have a lot of advantages - the general rule n http://gerrit.cloudera.org:8080/#/c/8025/6//COMMIT_MSG@31 PS6, Line 31: Remove FunctionContext::ReallocateLocal() > Oh, I was confused because it says FunctionContext not FunctionContextImpl. Ah I had the wrong class name. http://gerrit.cloudera.org:8080/#/c/8025/6/be/src/exec/exec-node.h File be/src/exec/exec-node.h: http://gerrit.cloudera.org:8080/#/c/8025/6/be/src/exec/exec-node.h@324 PS6, Line 324: expr-managed > I was reading it to say that the mem-pool was managed by the exprs, but I g Yeah that makes sense to me. Maybe tmp_mem_pool_ and perm_mem_pool_ or expr_tmp_mem_pool_ and expr_perm_mem_pool_. We do currently track expr allocations separately, which has some diagnostic value, although probably less now that buffer pool memory is separated out. Anyway we can talk more in person. -- To view, visit http://gerrit.cloudera.org:8080/8025 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ba5a7542ed90a49a4b5586c040b5985a7d45b61 Gerrit-Change-Number: 8025 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 22 Sep 2017 17:25:11 +0000 Gerrit-HasComments: Yes
