Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8123 )
Change subject: IMPALA-5870: Improve runtime profile for partial sort ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8123/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8123/1//COMMIT_MSG@14 PS1, Line 14: This patch removes the counters 'SpilledRuns' and 'MergesPerformed' > I'm skeptical about this part of the change. It definitely a wart but there Sounds good to me. I removed the EXPLAIN related stuff from this patch, and filed IMPALA-5972 http://gerrit.cloudera.org:8080/#/c/8123/1/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: http://gerrit.cloudera.org:8080/#/c/8123/1/be/src/runtime/sorter.cc@1520 PS1, Line 1520: initial_runs_ > "runs_counter_" is a bit inaccurate for spilling sorts since it doesn't inc Done -- To view, visit http://gerrit.cloudera.org:8080/8123 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b15af78d8299db8edc44ff820c85db1cbe0be1b Gerrit-Change-Number: 8123 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sat, 23 Sep 2017 00:05:12 +0000 Gerrit-HasComments: Yes
