Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/6535 )
Change subject: IMPALA-2550: Switch to per-query exec rpc ...................................................................... Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/6535/15/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/6535/15/be/src/runtime/coordinator-backend-state.cc@363 PS15, Line 363: local_params.__set_bloom_filter(rpc_params->bloom_filter); Sorry for commenting on an old CR. I'm reading this part of code and have several questions: 1. Why does rpc_params need to be a shared_ptr? I think it is only referenced within the scope of this function. 2. Why is a copy made here? 2. Why is __set_bloom_filter called, given that local_params is copy-constructed from rpc_params? -- To view, visit http://gerrit.cloudera.org:8080/6535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20769e420711737b6b385c744cef4851cee3facd Gerrit-Change-Number: 6535 Gerrit-PatchSet: 15 Gerrit-Owner: Marcel Kornacker <marc...@gmail.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Marcel Kornacker <marc...@gmail.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 25 Sep 2017 22:33:49 +0000 Gerrit-HasComments: Yes
