Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8140 )
Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8140/4/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/8140/4/tests/common/impala_test_suite.py@103 PS4, Line 103: SET_PATTERN = re.compile(r'\s*set\s*([a-zA-Z_][a-zA-Z0-9_]*)\s*=*', re.I) I think this shouldn't sneak in here but instead go into a separate commit. Thanks. -- To view, visit http://gerrit.cloudera.org:8080/8140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I026a0123b035b6828ef35b599dda50aadf0171bb Gerrit-Change-Number: 8140 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Wood <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Comment-Date: Thu, 28 Sep 2017 16:09:37 +0000 Gerrit-HasComments: Yes
