Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8168 )
Change subject: IMPALA-4951: Fix database visibility for user with only column privilege ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8168/1/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test File testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test: http://gerrit.cloudera.org:8080/#/c/8168/1/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test@761 PS1, Line 761: root Why are you using root and not $GROUP_NAME for this test? http://gerrit.cloudera.org:8080/#/c/8168/1/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test@786 PS1, Line 786: # IMPALA-4951: make sure database is visible to a user having only column level access : # to a table in the database : show databases : ---- RESULTS : 'default','Default Hive database' : 'grant_rev_db','' : ---- TYPES : STRING,STRING : ==== I think the test for this jira should work as follows: 1. You have/create a db/table for which user has no privileges. 2. You do show databases and verify the db is not listed 3. You add a column privilege on the table. 4. You do show databases and see that db is now listed. -- To view, visit http://gerrit.cloudera.org:8080/8168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id77904876729c0223fd6ace2d5e7199bd700a33a Gerrit-Change-Number: 8168 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Comment-Date: Thu, 28 Sep 2017 18:44:02 +0000 Gerrit-HasComments: Yes
