Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8085 )
Change subject: IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/8085/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8085/6//COMMIT_MSG@44 PS6, Line 44: There is a significant regression (50% increase in runtime) in > Thanks for the experiment. I'm in favor of moving forward, but still a litt I think the upside is that simplifying the Parquet code incrementally makes it easier to optimise in future. We have plenty of scope to optimise CPU efficiency in future in ways that will benefit most queries. I.e. I wouldn't spend time optimising the uncompressed strings case, rather just try to make it overall more CPU efficient. -- To view, visit http://gerrit.cloudera.org:8080/8085 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I767c1e2dabde7d5bd7a4d5c1ec6d14801b8260d2 Gerrit-Change-Number: 8085 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 28 Sep 2017 23:57:32 +0000 Gerrit-HasComments: Yes
