Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8025 )
Change subject: IMPALA-5844: use a MemPool for expr result allocations ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/8025/9/be/src/exprs/agg-fn-evaluator.h File be/src/exprs/agg-fn-evaluator.h: http://gerrit.cloudera.org:8080/#/c/8025/9/be/src/exprs/agg-fn-evaluator.h@175 PS9, Line 175: static void Serialize(const std::vector<AggFnEvaluator*>& evals, Tuple* dst); > I don't think we can change the UDAF interfaces right now to thread the arg Yeah, we can't change the UDA interface. But was pondering whether the evaluator interface should change to make it explicit (and then we could consider changing the UDA interface later to line them up when we break UDF compat). I think generally the FunctionContext interface is a mess. But maybe it doesn't work out to be an improvement. But this swapping also seems a bit confusing. -- To view, visit http://gerrit.cloudera.org:8080/8025 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ba5a7542ed90a49a4b5586c040b5985a7d45b61 Gerrit-Change-Number: 8025 Gerrit-PatchSet: 10 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 29 Sep 2017 00:22:35 +0000 Gerrit-HasComments: Yes
