Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8164 )
Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Linking doesn't seem necessary to me - I think the documentation is easily discoverable by search (both the wiki page and the docs themselves) http://gerrit.cloudera.org:8080/#/c/8164/4/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/8164/4/be/src/common/global-flags.cc@105 PS4, Line 105: "to create minidumps on demand without exiting the process by sending SIGUSR1. " Thanks this is better than my suggestion. -- To view, visit http://gerrit.cloudera.org:8080/8164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0 Gerrit-Change-Number: 8164 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 29 Sep 2017 16:25:02 +0000 Gerrit-HasComments: Yes
