Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8096 )
Change subject: Re-apply: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options ...................................................................... Patch Set 3: > Patch Set 3: > > > Patch Set 3: > > > > Is this the same patch as before (I.e. can we just carry forward that +2), > > or did something in this diff change since the +2? > > This is a computer-generated revert-of-a-revert with a slight change to the > commit message. > > I double checked with git patch-id; they're the same diff. > > $git log --oneline --grep IMPALA-5589 | grep -v Revert > 598b72c Re-apply: IMPALA-5589: change "set" in impala-shell to show empty > string for unset query options > 387bde0 IMPALA-5589: change "set" in impala-shell to show empty string for > unset query options > > $git show 387bde0 | git-patch-id --stable; git show 598b72c | git-patch-id > --stable > 47b02290d8b30ffa520ea19dac8353075c5a5bc7 > 387bde0639ffd8ef580ccbf727152954e62bacbe > 47b02290d8b30ffa520ea19dac8353075c5a5bc7 > 598b72cf43a326dd3c8a9a35994f8007db665b93 And, yes, I think we should carry forward the +2. -- To view, visit http://gerrit.cloudera.org:8080/8096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29f5d8ab874cb1338077f16019a9537766cac0c4 Gerrit-Change-Number: 8096 Gerrit-PatchSet: 3 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Fri, 29 Sep 2017 22:57:19 +0000 Gerrit-HasComments: No
