Matthew Mulder has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 )
Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. ...................................................................... Patch Set 12: The stress test is at tests/stress/concurrent_select.py. The list of queries to run is created in load_tpc_queries(). The queries are initially executed in populate_all_queries(). Any query error in populate_all_queries() seems to be fatal. I see two general choices: 1. Do something in load_tpc_queries() to blacklist the unsupported queries. 2. Do something in main() before calling populate_all_queries() to remove the unsupported queries. There are a few options for what "do something" would be. I wouldn't recommend simply skipping queries with errors in populate_all_queries() because that could conceal a regression. -- To view, visit http://gerrit.cloudera.org:8080/8102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e284888600a7a69d1f23fcb7dac21cbb13b7d66 Gerrit-Change-Number: 8102 Gerrit-PatchSet: 12 Gerrit-Owner: Tim Wood <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Matthew Mulder <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Wood <[email protected]> Gerrit-Comment-Date: Sat, 30 Sep 2017 00:59:02 +0000 Gerrit-HasComments: No
