Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8074 )
Change subject: IMPALA-5174: Suppress kudu flags that aren't relevant to Impala ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/8074/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8074/1//COMMIT_MSG@12 PS1, Line 12: #include-d in Impala code > Do we know why this is the case ? I don't see DECLARE_FLAG() in all header Only gflags in .cc files which aren't dead code will show up, right ? Please clarify this comment. Simply #include a header file doesn't mean the gflags defined in the .cc file corresponding to the .h file will be included, right ? -- To view, visit http://gerrit.cloudera.org:8080/8074 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I499c903cde92595c4a02803ecbf98ac1d41517b4 Gerrit-Change-Number: 8074 Gerrit-PatchSet: 1 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Comment-Date: Wed, 04 Oct 2017 00:13:58 +0000 Gerrit-HasComments: Yes
