Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8147 )
Change subject: IMPALA-5448: fix invalid number of splits reported in Parquet scan node ...................................................................... Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/8147/2/be/src/exec/hdfs-scan-node-base.h File be/src/exec/hdfs-scan-node-base.h: http://gerrit.cloudera.org:8080/#/c/8147/2/be/src/exec/hdfs-scan-node-base.h@557 PS2, Line 557: > Should call BitUtil::Popcount(), which will use hardware acceleration if ap Done http://gerrit.cloudera.org:8080/#/c/8147/2/be/src/exec/hdfs-scan-node-base.h@579 PS2, Line 579: > We put an underscore at the end of private members, i.e. 'bit_map_' Oops, forgot it! Done http://gerrit.cloudera.org:8080/#/c/8147/2/be/src/exec/hdfs-scan-node-base.h@582 PS2, Line 582: > Not your change, but it should mention the second entry in the tuple - whet Done. Change to: /// Mapping of file formats to the number of splits of that type. The key is a tuple /// containing: /// * file type /// * whether the split was skipped /// * compression types set http://gerrit.cloudera.org:8080/#/c/8147/2/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/8147/2/testdata/datasets/functional/functional_schema_template.sql@1581 PS2, Line 1581: -- IMPALA-1658: Timestamps written by Hive are local-to-UTC adjusted. > We moved to loading "special" files as part of the tests rather than part o Done http://gerrit.cloudera.org:8080/#/c/8147/2/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/8147/2/tests/query_test/test_scanners.py@82 PS2, Line 82: # Test all the scanners with a simple limit clause. The limit clause triggers > This only applies to parquet so should go in TestParquet below (TestScanner Done http://gerrit.cloudera.org:8080/#/c/8147/2/tests/query_test/test_scanners.py@337 PS2, Line 337: " stored as parquet" % unique_database) > This is an example of the alternative way of loading data files as part of Great! Done -- To view, visit http://gerrit.cloudera.org:8080/8147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaacc2d775032f5707061e704f12e0a63cde695d1 Gerrit-Change-Number: 8147 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 04 Oct 2017 12:13:40 +0000 Gerrit-HasComments: Yes
