Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8145 )
Change subject: IMPALA-5988: optimise MemPool::TryAllocate() ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/8145/3/be/src/runtime/mem-pool.h File be/src/runtime/mem-pool.h: http://gerrit.cloudera.org:8080/#/c/8145/3/be/src/runtime/mem-pool.h@123 PS3, Line 123: Allocate<true>(size, 1); TryAllocateAligned(size, 1); seems a bit clearer to me (then it's clearer this is just syntactic sugar over the core API). -- To view, visit http://gerrit.cloudera.org:8080/8145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I088012084fe535a67a3cd1103ced5a02027f961a Gerrit-Change-Number: 8145 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Comment-Date: Wed, 04 Oct 2017 17:18:46 +0000 Gerrit-HasComments: Yes
