John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8191 )
Change subject: IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/8191/2/docs/topics/impala_alter_table.xml File docs/topics/impala_alter_table.xml: http://gerrit.cloudera.org:8080/#/c/8191/2/docs/topics/impala_alter_table.xml@67 PS2, Line 67: ] > extraneous? Done http://gerrit.cloudera.org:8080/#/c/8191/2/docs/topics/impala_alter_table.xml@69 PS2, Line 69: COMMENT '<varname>comment_text</varname>' > This does parse, but it will always give an error because Kudu doesn't supp Done. Let's take out this COMMENT part because I added lines 73-75 for SET COMMENT for non-Kudu tables. http://gerrit.cloudera.org:8080/#/c/8191/2/docs/topics/impala_alter_table.xml@71 PS2, Line 71: { > missing the closing '}' Done http://gerrit.cloudera.org:8080/#/c/8191/2/docs/topics/impala_alter_table.xml@1038 PS2, Line 1038: any newly inserted rows > These attributes may in some cases end up applied to existing rows as Kudu Done -- To view, visit http://gerrit.cloudera.org:8080/8191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7647dfe8acfdb598caf561d41d74e38a8b66ce9d Gerrit-Change-Number: 8191 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell <[email protected]> Gerrit-Reviewer: Ambreen Kazi <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 04 Oct 2017 18:02:06 +0000 Gerrit-HasComments: Yes
