John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8003 )
Change subject: IMPALA-3200: [DOCS] Document user-facing aspects of new buffer pool ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_buffer_pool_limit.xml File docs/topics/impala_buffer_pool_limit.xml: http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_buffer_pool_limit.xml@53 PS4, Line 53: MiB > MB. I may have mixed up MB / KB and MiB / KiB in a few places throughout. M Done http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_max_row_size.xml File docs/topics/impala_max_row_size.xml: http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_max_row_size.xml@68 PS4, Line 68: <codeblock><![CDATA[ > This example is really helpful! Hopefully this will head off some support c Done. TY. That was also a good catch by you of the outdated spilling details. http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_max_row_size.xml@82 PS4, Line 82: 500 KB string and a 30 KB > These are actually KiB. I didn't mean to actually cut it so close (530,000 Done http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_max_row_size.xml@95 PS4, Line 95: KiB > Agh, KiB again where it should be KB. Done http://gerrit.cloudera.org:8080/#/c/8003/4/docs/topics/impala_max_row_size.xml@109 PS4, Line 109: Increase the max_row_size query option (currently 512.00 KB) to process larger rows. > Wrap these very long error message lines. Done -- To view, visit http://gerrit.cloudera.org:8080/8003 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49323f8ffbff3e195058e88762eedbb1fcb1bc0e Gerrit-Change-Number: 8003 Gerrit-PatchSet: 4 Gerrit-Owner: John Russell <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 05 Oct 2017 00:29:35 +0000 Gerrit-HasComments: Yes
