Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7061 )
Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer ...................................................................... Patch Set 14: Verified+1 > Thanks! Also thanks to you and Henry for taking the time to review. > (technically my 2nd patch, I removed an invalid DCHECK a few months > ago, but it is my first patch of substance) > I'll probably start working in my spare time on IMPALA-5393 for my > next contribution. > > > > It looks like it passed gerri-verify-external - > https://jenkins.impala.io/job/gerrit-verify-dryrun-external/13/ > > > > Great! I'll rebase and merge this. > > Congratulations on getting your first patch in! Sure thing! Please feel free to reach out at any time. Your commit can be viewed here: https://github.com/apache/incubator-impala/commit/4dd0f1b3d84f67eb40bf671160b057be9bbdb921 -- To view, visit http://gerrit.cloudera.org:8080/7061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255 Gerrit-Change-Number: 7061 Gerrit-PatchSet: 14 Gerrit-Owner: John Sherman <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Sherman <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Comment-Date: Thu, 05 Oct 2017 05:41:44 +0000 Gerrit-HasComments: No
