John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8046 )
Change subject: IMPALA-2190: [DOCS] from_timestamp() and to_timestamp() ...................................................................... Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/8046/2/docs/topics/impala_datetime_functions.xml File docs/topics/impala_datetime_functions.xml: http://gerrit.cloudera.org:8080/#/c/8046/2/docs/topics/impala_datetime_functions.xml@791 PS2, Line 791: For efficient date and time calculations, where possible you store temporal > Strange sentence: either? I think this was transposed over from my draft where I was writing up from_timestamp() and to_timestamp() at the same time. to_timestamp() also covers the case where you are storing date/time as BIGINT. Why don't I delete this sentence here. http://gerrit.cloudera.org:8080/#/c/8046/2/docs/topics/impala_datetime_functions.xml@794 PS2, Line 794: into arbitrary formats for reporting purposes. > into arbitrary string formats Done http://gerrit.cloudera.org:8080/#/c/8046/2/docs/topics/impala_datetime_functions.xml@797 PS2, Line 797: Because Impala implicitly converts string values in the recognized <codeph>yyyy-MM-dd HH:mm:ss</codeph> > Slightly inaccurate. I'd recommend rephrasing to something like: Done http://gerrit.cloudera.org:8080/#/c/8046/2/docs/topics/impala_datetime_functions.xml@799 PS2, Line 799: dates/times directly to a different format in your query output. > to a different format using from_timestamp() Done http://gerrit.cloudera.org:8080/#/c/8046/2/docs/topics/impala_datetime_functions.xml@815 PS2, Line 815: -- Reformat string literal representing date/time. > Nice example! Done http://gerrit.cloudera.org:8080/#/c/8046/2/docs/topics/impala_datetime_functions.xml@824 PS2, Line 824: select from_timestamp('1984-09-25', 'MMM dd, yyyy'); > Might be good to have a complete example that makes use of all the timestam Done http://gerrit.cloudera.org:8080/#/c/8046/2/docs/topics/impala_datetime_functions.xml@2188 PS2, Line 2188: A string argument, plus another string argument representing the > Need to document the pattern pieces and their meaning, e.g.: You know, I thought the complete list was under EXTRACT or TRUNC but now I don't see anything that matches up exactly. E.g. SYYYY isn't recognized for year; I can't find any variation like Mon that spells out the entire month instead of the short form. The closest is probably the explanation under from_unixtime(). Let's make that optional for this go-round, I'll mention from_unixtime() as the source of truth for now. -- To view, visit http://gerrit.cloudera.org:8080/8046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f6dfd3fb99a70975d712bbef6c05900eddadd27 Gerrit-Change-Number: 8046 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Andre Calfa <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Comment-Date: Fri, 06 Oct 2017 05:56:01 +0000 Gerrit-HasComments: Yes
