Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 )
Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala ...................................................................... Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/7954/11/be/src/exprs/cast-functions-ir.cc File be/src/exprs/cast-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/7954/11/be/src/exprs/cast-functions-ir.cc@277 PS11, Line 277: } > They are exercised by different parts of be/exprs/expr-test.cc .I have sear I mean the warning messages that you're adding here have no verification. http://gerrit.cloudera.org:8080/#/c/7954/11/be/src/runtime/timestamp-test.cc File be/src/runtime/timestamp-test.cc: http://gerrit.cloudera.org:8080/#/c/7954/11/be/src/runtime/timestamp-test.cc@670 PS11, Line 670: * > I can change this, but I prefer it this way actually. What is the rule, sho Yes, we should follow the style guide so we have a consistent style, which overall makes the code more readable. I'm sure everyone has something that they dislike about the style, but we need consistency. http://gerrit.cloudera.org:8080/#/c/7954/11/be/src/runtime/timestamp-value.h File be/src/runtime/timestamp-value.h: http://gerrit.cloudera.org:8080/#/c/7954/11/be/src/runtime/timestamp-value.h@43 PS11, Line 43: 9999 > This comment was just wrong, we state <= 9999-12-31 or <10000-01-01 everywh Okay, thanks for confirming. http://gerrit.cloudera.org:8080/#/c/7954/11/be/src/runtime/timestamp-value.cc File be/src/runtime/timestamp-value.cc: http://gerrit.cloudera.org:8080/#/c/7954/11/be/src/runtime/timestamp-value.cc@116 PS11, Line 116: ( > Done still not fixed: if (HasDate()... -- To view, visit http://gerrit.cloudera.org:8080/7954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77b2f6284d3a597f57e61c17a67c959eff9e38ff Gerrit-Change-Number: 7954 Gerrit-PatchSet: 11 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Comment-Date: Fri, 06 Oct 2017 17:27:05 +0000 Gerrit-HasComments: Yes
