Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/7999 )
Change subject: [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml@1247 PS2, Line 1247: does not affect > fair pointer for me, but my comment is about whether this wording is clear Fine with me to expand this to add my earlier explanation of what the "incremental" part of the stats actually is (to explain why dropping the "incremental" portion is fine). http://gerrit.cloudera.org:8080/#/c/7999/2/docs/shared/impala_common.xml@1248 PS2, Line 1248: optimizations such as partition pruning. > such as partition pruning or join ordering. Actually I would remove partition pruning because stats have nothing to do with that (and we don't want to imply that they do) -- To view, visit http://gerrit.cloudera.org:8080/7999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia53a6518ce5541e5c9a2cd896856ce042a599b03 Gerrit-Change-Number: 7999 Gerrit-PatchSet: 2 Gerrit-Owner: John Russell <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Silvius Rus <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 06 Oct 2017 17:46:39 +0000 Gerrit-HasComments: Yes
