sandeep akinapelli has posted comments on this change. ( http://gerrit.cloudera.org:8080/7353 )
Change subject: IMPALA-2636: HS2 GetTables() returns TABLE_TYPE as TABLE for VIEW ...................................................................... Patch Set 4: (4 comments) addressed more comments. http://gerrit.cloudera.org:8080/#/c/7353/3/fe/src/main/java/org/apache/impala/service/MetadataOp.java File fe/src/main/java/org/apache/impala/service/MetadataOp.java: http://gerrit.cloudera.org:8080/#/c/7353/3/fe/src/main/java/org/apache/impala/service/MetadataOp.java@496 PS3, Line 496: tableType = tableType.toUpperCase(); > I think the toUpperCase() here should stay. Done http://gerrit.cloudera.org:8080/#/c/7353/3/fe/src/main/java/org/apache/impala/service/MetadataOp.java@497 PS3, Line 497: upperCaseTableTypes.add(tableType); > You can use equals() if you leave the toUpperCase() above. Done http://gerrit.cloudera.org:8080/#/c/7353/3/fe/src/test/java/org/apache/impala/service/FrontendTest.java File fe/src/test/java/org/apache/impala/service/FrontendTest.java: http://gerrit.cloudera.org:8080/#/c/7353/3/fe/src/test/java/org/apache/impala/service/FrontendTest.java@181 PS3, Line 181: TMetadataOpRequest req = new TMetadataOpRequest(); > space after "default" not a relevant comment. removed http://gerrit.cloudera.org:8080/#/c/7353/3/fe/src/test/java/org/apache/impala/service/FrontendTest.java@209 PS3, Line 209: TResultSet resp = execMetadataOp(req); > Does this test succeed when run on its own? For these views to be returned right. this could be flakey. added analyze statements to make sure these are loaded. -- To view, visit http://gerrit.cloudera.org:8080/7353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90616388e6181cf342b3de389af940214ed46428 Gerrit-Change-Number: 7353 Gerrit-PatchSet: 4 Gerrit-Owner: sandeep akinapelli <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: sandeep akinapelli <[email protected]> Gerrit-Comment-Date: Fri, 06 Oct 2017 23:06:58 +0000 Gerrit-HasComments: Yes
